How to contribute code - Revision history

Dereckson: /* Useful links */

2025-11-12T09:49:54Z

Useful links

← Older revision		Revision as of 09:49, 12 November 2025
Line 274:		Line 274:
	* http://chris.beams.io/posts/git-commit/		* http://chris.beams.io/posts/git-commit/
	* https://devcentral.nasqueron.org/w/setup_2fa/		* https://devcentral.nasqueron.org/w/setup_2fa/
			* https://eagain.net/articles/git-for-computer-scientists/

	[[Category:Reference]]		[[Category:Reference]]
	[[Category:Contributor guide]]		[[Category:Contributor guide]]
	[[Category:Internship guide]]		[[Category:Internship guide]]

Dereckson: /* datacube: permissions issues */

2025-09-20T14:56:16Z

datacube: permissions issues

← Older revision		Revision as of 14:56, 20 September 2025
Line 264:		Line 264:
	Note the easiest way is to add the write permission to the group:		Note the easiest way is to add the write permission to the group:

			$ cd /datacube/git/<repository>
	$ find . -type d \| xargs chmod g+w		$ find . -type d \| xargs chmod g+w
	$ find . -type f \| xargs chmod g+w		$ find . -type f \| xargs chmod g+w

Dereckson: /* datacube: permissions issues */

2025-09-20T14:55:58Z

datacube: permissions issues

← Older revision		Revision as of 14:55, 20 September 2025
Line 262:		Line 262:
	If you have access to datacube, your group, nasquenautes, is normally the owner of the Git repository directory, you have so the right to do it yourself, excepted if the repository itself is still in 755 and not in 775. In that case or if you don't feel comfortable to fix it yourself in the /datacube/git directory, open a task on DevCentral to get assistance.		If you have access to datacube, your group, nasquenautes, is normally the owner of the Git repository directory, you have so the right to do it yourself, excepted if the repository itself is still in 755 and not in 775. In that case or if you don't feel comfortable to fix it yourself in the /datacube/git directory, open a task on DevCentral to get assistance.

	Note: ~~the~~ autochmod-git script on Complector deals with repository CONTENT/workspace, not with a bare repository or with the .git folder of a regular repository, so you can't directly use it.		Note the easiest way is to add the write permission to the group:

			$ find . -type d \| xargs chmod g+w
			$ find . -type f \| xargs chmod g+w

			The autochmod-git script on Complector deals with repository CONTENT/workspace, not with a bare repository or with the .git folder of a regular repository, so you can't directly use it.

	== Useful links ==		== Useful links ==

Dereckson: /* datacube: permissions issues */

2025-09-20T14:54:03Z

datacube: permissions issues

← Older revision		Revision as of 14:54, 20 September 2025
Line 260:		Line 260:
	The basic idea is to use 775 664 for the repository directories and files, instead of the default 755 644, so user and group can maintain them.		The basic idea is to use 775 664 for the repository directories and files, instead of the default 755 644, so user and group can maintain them.

	If you have access to datacube, your group, nasquenautes, is the owner of the Git repository directory, you have so the right to do it yourself. ~~Permissions issues can be tricky on shared repositories, so~~ if you don't feel comfortable to fix it yourself in the /datacube/git directory, open a task on DevCentral to get assistance.		If you have access to datacube, your group, nasquenautes, is normally the owner of the Git repository directory, you have so the right to do it yourself, excepted if the repository itself is still in 755 and not in 775. In that case or if you don't feel comfortable to fix it yourself in the /datacube/git directory, open a task on DevCentral to get assistance.

	Note: the autochmod-git script on Complector deals with repository CONTENT/workspace, not with a bare repository or with the .git folder of a regular repository, so you can't directly use it.		Note: the autochmod-git script on Complector deals with repository CONTENT/workspace, not with a bare repository or with the .git folder of a regular repository, so you can't directly use it.

Dereckson: /* Troubleshoot Arcanist */

2025-09-20T14:52:40Z

Troubleshoot Arcanist

← Older revision		Revision as of 14:52, 20 September 2025
Line 189:		Line 189:
	The review should contain a comment about what is broken in the reverted commit, excepted if there is already such information in Audit or Differential.		The review should contain a comment about what is broken in the reverted commit, excepted if there is already such information in Audit or Differential.

	== Troubleshoot ~~Arcanist~~ ==		== Troubleshoot ==
	=== Install Arcanist like on Nasqueron devserver role ===		=== Install Arcanist like on Nasqueron devserver role ===

Line 206:		Line 206:
	</syntaxhighlight>		</syntaxhighlight>

	=== Use Nasqueron maintained patches ===		=== Use Nasqueron maintained patches for Arcanist ===
	If you wish to get upstream + a patch to use by default main and not master branch name + PHPUnit support		If you wish to get upstream + a patch to use by default main and not master branch name + PHPUnit support
	you can clone the '''production''' branch at https:/github.com/nasqueron/arcanist (it's the default branch).		you can clone the '''production''' branch at https:/github.com/nasqueron/arcanist (it's the default branch).

	=== PHPUnit7+ support ===		=== PHPUnit7+ support in Arcanist ===
	You can apply [https://secure.phabricator.com/P2084 this patch] to get a working Arcanist on the upstream version:		You can apply [https://secure.phabricator.com/P2084 this patch] to get a working Arcanist on the upstream version:

Line 245:		Line 245:

	Then, inject that timestamp to git: <code>git commit --amend --date=1535846555</code>		Then, inject that timestamp to git: <code>git commit --amend --date=1535846555</code>

			=== datacube: detected dubious ownership in repository ===

			If you want to interact with datacube to exchange draft branches, Git can complain the folder belongs to the deploy user, not you.

			It's not in your local Git you need

			$ ssh windriver.nasqueron.org git config --global --add safe.directory /datacube/git/reports.git

			=== datacube: permissions issues ===

			An example of message: <code>error: remote unpack failed: unable to create temporary object directory</code>

			The basic idea is to use 775 664 for the repository directories and files, instead of the default 755 644, so user and group can maintain them.

			If you have access to datacube, your group, nasquenautes, is the owner of the Git repository directory, you have so the right to do it yourself. Permissions issues can be tricky on shared repositories, so if you don't feel comfortable to fix it yourself in the /datacube/git directory, open a task on DevCentral to get assistance.

			Note: the autochmod-git script on Complector deals with repository CONTENT/workspace, not with a bare repository or with the .git folder of a regular repository, so you can't directly use it.

	== Useful links ==		== Useful links ==

Dereckson: /* Troubleshoot Arcanist */

2024-11-11T13:57:58Z

Troubleshoot Arcanist

← Older revision		Revision as of 13:57, 11 November 2024
Line 236:		Line 236:

	$ composer install		$ composer install

			=== arc patch changed the commit date ===

			You can recover the unix timestamp of the change from the devcentral_differential database with the correct HH:MM:SS expected granularity. For example for D1656:

			$ bin/storage shell
			SELECT min(dateCreated) FROM devcentral_differential.differential_diff WHERE revisionID = 1656;

			Then, inject that timestamp to git: <code>git commit --amend --date=1535846555</code>

	== Useful links ==		== Useful links ==

Dereckson: Some hints for dependencies

2024-10-25T17:00:10Z

Some hints for dependencies

@@ Line 16: / Line 16: @@
 If you want to edit a Keruald library, clone the monorepo and not directly the read-only repo of the library. This is intended to ease development across dependent libraries.
 == Code something ==
@@ Line 210: / Line 227: @@
 $ git commit -a -m "Support PHPUnit 7+"
 ‎</syntaxhighlight>
 == Useful links ==

Dereckson at 21:20, 24 October 2024

2024-10-24T21:20:52Z

← Older revision		Revision as of 21:20, 24 October 2024
Line 217:		Line 217:

	[[Category:Reference]]		[[Category:Reference]]
			[[Category:Contributor guide]]
			[[Category:Internship guide]]

Dereckson: /* Code it */ use newer Git commands

2024-09-08T20:29:24Z

Code it: use newer Git commands

← Older revision		Revision as of 20:29, 8 September 2024
Line 39:		Line 39:
	Before to start to code, create a new branch:		Before to start to code, create a new branch:

	git ~~checkout~~ -b feature/something-awesome		git switch -c feature/something-awesome

	If you fix a bug, use the number of the bug on DevCentral:		If you fix a bug, use the number of the bug on DevCentral:

	git ~~checkout~~ -b bug/T434		git switch -c bug/T434

	Then code something, test it, reread it.		Then code something, test it, reread it.

Dereckson: /* Accept a revision */

2024-07-29T18:52:01Z

Accept a revision

← Older revision		Revision as of 18:52, 29 July 2024
Line 123:		Line 123:
	Consider to '''land accepted revisions immediately'''.		Consider to '''land accepted revisions immediately'''.
	</div>		</div>

	~~Note: for Salt, that works slightly differently: a test deployment is required before landing, and self review is allowed when a member of the team is alone, and the matter trivial or urgent.~~

	~~As of July 2024, Dorian and Dereckson are glad to perform code reviews of your changes.~~

	==== What does that mean? ====		==== What does that mean? ====